Messages in this thread | | | Date | Fri, 17 May 2024 11:10:41 -0400 | From | "Theodore Ts'o" <> | Subject | Re: [PATCH v3] ext4: Don't reduce symlink i_mode by umask if no ACL support |
| |
On Fri, May 10, 2024 at 12:47:21PM +0100, David Howells wrote: > > If CONFIG_EXT4_FS_POSIX_ACL=n then the fallback version of ext4_init_acl() > will mask off the umask bits from the new inode's i_mode. This should not > be done if the inode is a symlink. If CONFIG_EXT4_FS_POSIX_ACL=y, then we > go through posix_acl_create() instead which does the right thing with > symlinks. > > However, this is actually unnecessary now as vfs_prepare_mode() has already > done this where appropriate, so fix this by making the fallback version of > ext4_init_acl() do nothing.
Thanks for this patch; however, as I had mentioned in the discussion of the v1 version the patch, this change is already in the ext4 tree and linux-next in commit c77194965dd0 ('Revert "ext4: apply umask if ACL support is disabled"').
- Ted
| |