Messages in this thread Patch in this message | | | Date | Sat, 8 Apr 2006 18:10:14 +0800 | From | "Coywolf Qi Hunt" <> | Subject | [patch] represent-dirty__centisecs-as-jiffies-internally.patch comment fix |
| |
2006/3/25, akpm@osdl.org <akpm@osdl.org>:
> From: Bart Samwel <bart@samwel.tk> > > Make that the internal values for: > > /proc/sys/vm/dirty_writeback_centisecs > /proc/sys/vm/dirty_expire_centisecs > > are stored as jiffies instead of centiseconds. Let the sysctl interface do > the conversions with full precision using clock_t_to_jiffies, instead of > doing overflow-sensitive on-the-fly conversions every time the values are > used.
> diff -puN mm/page-writeback.c~represent-dirty__centisecs-as-jiffies-internally mm/page-writeback.c > --- devel/mm/page-writeback.c~represent-dirty__centisecs-as-jiffies-internally 2006-03-24 03:00:41.000000000 -0800 > +++ devel-akpm/mm/page-writeback.c 2006-03-24 03:00:41.000000000 -0800 > @@ -75,12 +75,12 @@ int vm_dirty_ratio = 40; > * The interval between `kupdate'-style writebacks, in centiseconds > * (hundredths of a second)
Bart,
You forgot to fix the comments. The attached patch fixes them. -- Coywolf Qi Hunt
Signed-off-by: Coywolf Qi Hunt <qiyong@fc-cn.com> ---
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 6dcce3a..75d7f48 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -72,13 +72,12 @@ int dirty_background_ratio = 10; int vm_dirty_ratio = 40; /* - * The interval between `kupdate'-style writebacks, in centiseconds - * (hundredths of a second) + * The interval between `kupdate'-style writebacks, in jiffies */ int dirty_writeback_interval = 5 * HZ; /* - * The longest number of centiseconds for which data is allowed to remain dirty + * The longest number of jiffies for which data is allowed to remain dirty */ int dirty_expire_interval = 30 * HZ; | |