Messages in this thread Patch in this message | | | Date | Sat, 29 Apr 2006 10:26:59 +0200 | From | Heiko Carstens <> | Subject | [patch 2/2] s390: bug in setup_rt_frame |
| |
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Consider return value of __put_user() when setting up a signal frame instead of ignoring it.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> ---
Second version of this patch. This time without replacing __NR_rt_sigreturn with __NR_sigreturn...
arch/s390/kernel/signal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/signal.c b/arch/s390/kernel/signal.c index ae1927e..d48cfc7 100644 --- a/arch/s390/kernel/signal.c +++ b/arch/s390/kernel/signal.c @@ -358,8 +358,9 @@ static int setup_rt_frame(int sig, struc } else { regs->gprs[14] = (unsigned long) frame->retcode | PSW_ADDR_AMODE; - err |= __put_user(S390_SYSCALL_OPCODE | __NR_rt_sigreturn, - (u16 __user *)(frame->retcode)); + if (__put_user(S390_SYSCALL_OPCODE | __NR_rt_sigreturn, + (u16 __user *)(frame->retcode))) + goto give_sigsegv; } /* Set up backchain. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |