Messages in this thread | | | Date | Fri, 28 Apr 2006 09:07:19 +0200 | From | "Jan Beulich" <> | Subject | [discuss] Re: [PATCH] [3/4] i386: Fix overflow in e820_all_mapped |
| |
>>> Linus Torvalds <torvalds@osdl.org> 28.04.06 07:39 >>> > > >On Fri, 28 Apr 2006, Andi Kleen wrote: >> >> The 32bit version of e820_all_mapped() needs to use u64 to avoid >> overflows on PAE systems. Pointed out by Jan Beulich > >I don't think that's true. > >It can't be called with 64-bit arguments anyway. If the base address >doesn't fit in 32-bit, we'd be screwed in other places, afaik.
The arguments don't necessarily need to be u64, but (at least some of) the calculations inside the function do. Otherwise, a region starting below 4G and extending to or beyond 4G would not be considered correctly.
Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |