lkml.org 
[lkml]   [2006]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [3/4] i386: Fix overflow in e820_all_mapped


On Fri, 28 Apr 2006, Andi Kleen wrote:
>
> Quoting jbeulich:
>
> The effect is not on the current user's parameter passing, but in the
> result the function may produce. If, say, for the PCI mmconfig and BIOS
> space, there is a (reserved) entry starting at E0000000 and being
> 20000000 in size, then as far as I can tell the function will return
> zero (rather than one).

Well, but that has nothing to do with the _calling_ convention.

That looks to be a totally internal bug to within e820_all_mapped().

I agree that the calling convention change would avoid the overflow
internally too, I just don't much like the explanation (and not
necessarily that it affects the caller, who doesn't much care).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.052 / U:1.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site