Messages in this thread | | | From | Nikita Danilov <> | Date | Tue, 25 Apr 2006 13:09:47 +0400 | Subject | Re: C++ pushback |
| |
J.A. Magallon writes:
[...]
> > Tell me what is the difference between: > > > sbi = kmalloc(sizeof(*sbi), GFP_KERNEL); > if (!sbi) > return -ENOMEM; > sb->s_fs_info = sbi; > memset(sbi, 0, sizeof(*sbi)); > sbi->s_mount_opt = 0; > sbi->s_resuid = EXT3_DEF_RESUID; > sbi->s_resgid = EXT3_DEF_RESGID; > > and > > SuperBlock() : s_mount_opt(0), s_resuid(EXT3_DEF_RESUID), s_resgid(EXT3_DEF_RESGID) > {} > > ... > sbi = new SuperBlock; > if (!sbi) > return -ENOMEM; > > apart that you don't get members initalized twice and get a shorter code :).
The difference is that second fragment doesn't mention GFP_KERNEL, so it's most likely wrong. Moreover it's shorter only because it places multiple initializations on the same like, hence, contradicting CodingStyle.
> > -- > J.A. Magallon <jamagallon()able!es> \ Software is like sex:
Nikita. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |