Messages in this thread | | | From | Dmitry Baryshkov <> | Date | Tue, 21 May 2024 13:01:05 +0300 | Subject | Re: [PATCH 06/12] remoteproc: qcom_q6v5_pas: switch to mbn files by default |
| |
On Tue, 21 May 2024 at 12:49, <neil.armstrong@linaro.org> wrote: > > On 21/05/2024 11:45, Dmitry Baryshkov wrote: > > We have been pushing userspace to use mbn files by default for ages. > > As a preparation for making the firmware-name optional, make the driver > > use .mbn instead of .mdt files by default. > > I think we should have a mechanism to fallback to .mdt since downstream > uses split mdt on the devices filesystem. > > Perhaps only specify .firmware_name = "adsp" and add a list of allowed extension > it will try in a loop ?
Such loops can cause unnecessary delays if the CONFIG_FW_LOADER_USER_HELPER is enabled. Since it is not possible to use vendor's firmware partition as is (you have to either bind-mount a subdir or use a plenty of symlinks) one might as well symlink .mbn to .mdt file. Another option is to explicitly specify something like `firmware-name = "./adsp.mdt";'
But yes, this whole series is a balance of pros and cons, as it was discussed last week.
-- With best wishes Dmitry
| |