Messages in this thread | | | Date | Fri, 10 May 2024 18:21:51 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v3] net: smc91x: Fix m68k kernel compilation for ColdFire CPU |
| |
On Fri, May 10, 2024 at 01:30:55PM +0200, Thorsten Blum wrote: > Compiling the m68k kernel with support for the ColdFire CPU family fails > with the following error: > > In file included from drivers/net/ethernet/smsc/smc91x.c:80: > drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_reset’: > drivers/net/ethernet/smsc/smc91x.h:160:40: error: implicit declaration of function ‘_swapw’; did you mean ‘swap’? [-Werror=implicit-function-declaration] > 160 | #define SMC_outw(lp, v, a, r) writew(_swapw(v), (a) + (r)) > | ^~~~~~ > drivers/net/ethernet/smsc/smc91x.h:904:25: note: in expansion of macro ‘SMC_outw’ > 904 | SMC_outw(lp, x, ioaddr, BANK_SELECT); \ > | ^~~~~~~~ > drivers/net/ethernet/smsc/smc91x.c:250:9: note: in expansion of macro ‘SMC_SELECT_BANK’ > 250 | SMC_SELECT_BANK(lp, 2); > | ^~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > The function _swapw() was removed in commit d97cf70af097 ("m68k: use > asm-generic/io.h for non-MMU io access functions"), but is still used in > drivers/net/ethernet/smsc/smc91x.h. > > Use ioread16be() and iowrite16be() to resolve the error. > > Fixes: d97cf70af097 ("m68k: use asm-generic/io.h for non-MMU io access functions") > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> > --- > Changes in v2: > - Use ioread16be() and iowrite16be() directly instead of re-adding > _swapw() as suggested by Arnd Bergmann and Andrew Lunn > > Changes in v3: > - Add Fixes: tag
This is for net.
Cc: <stable@vger.kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |