lkml.org 
[lkml]   [2024]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY binding
On Fri, May 10, 2024 at 04:52:22PM +0100, Conor Dooley wrote:
> On Fri, May 10, 2024 at 10:38:49AM -0500, Rob Herring wrote:
> > On Thu, May 09, 2024 at 01:56:20PM +0800, Richard Zhu wrote:
> > > + fsl,refclk-pad-mode:
> > > + description:
> > > + Specifies the mode of the refclk pad used. INPUT(PHY refclock is
> > > + provided externally via the refclk pad) or OUTPUT(PHY refclock is
> > > + derived from SoC internal source and provided on the refclk pad).
> > > + $ref: /schemas/types.yaml#/definitions/string
> > > + enum: [ "input", "output" ]
> >
> > default?
> >
> > Really, this could just be a boolean for the non-default mode.
>
> There's actually a third option, or at least there was in v1, unused.
> The description in v1 was:
>
> It can be UNUSED(PHY
> refclock is derived from SoC internal source), INPUT(PHY refclock
> is provided externally via the refclk pad) or OUTPUT(PHY refclock
> is derived from SoC internal source and provided on the refclk pad).
>
> I suggested that there should be 3 strings and not having the property
> would mean unused. But all mention of unused seems to have vanished :/

Yes, missed mention about unused.

Is it okay about "fsl,refclk-pad-mode not exist means unused ?

Of course, need mention in description.


Frank


\
 
 \ /
  Last update: 2024-05-27 18:24    [W:0.048 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site