lkml.org 
[lkml]   [2024]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH v2] media: ipu-bridge: fix error code in ipu_bridge_init()
Return -EINVAL if "bridge->n_sensors == 0".  Don't return success.

Fixes: 881ca25978c6 ("media: ipu3-cio2: rename cio2 bridge to ipu bridge and move out of ipu3")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
v2: style change

drivers/media/pci/intel/ipu-bridge.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
index 61750cc98d70..44a9d9c15b05 100644
--- a/drivers/media/pci/intel/ipu-bridge.c
+++ b/drivers/media/pci/intel/ipu-bridge.c
@@ -839,9 +839,14 @@ int ipu_bridge_init(struct device *dev,
bridge->data_lanes[i] = i + 1;

ret = ipu_bridge_connect_sensors(bridge);
- if (ret || bridge->n_sensors == 0)
+ if (ret)
goto err_unregister_ipu;

+ if (bridge->n_sensors == 0) {
+ ret = -EINVAL;
+ goto err_unregister_ipu;
+ }
+
dev_info(dev, "Connected %d cameras\n", bridge->n_sensors);

fwnode = software_node_fwnode(&bridge->ipu_hid_node);
--
2.43.0

\
 
 \ /
  Last update: 2024-05-27 18:24    [W:0.090 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site