lkml.org 
[lkml]   [2024]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: ipu-bridge: fix error code in ipu_bridge_init()
On Fri, May 10, 2024 at 06:18:22PM +0300, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 06:10:37PM +0300, Dan Carpenter wrote:
> > Return -EINVAL if "bridge->n_sensors == 0". Don't return success.
>
> ...
>
> > ret = ipu_bridge_connect_sensors(bridge);
> > - if (ret || bridge->n_sensors == 0)
> > + if (ret || bridge->n_sensors == 0) {
> > + ret = ret ?: -EINVAL;
> > goto err_unregister_ipu;
> > + }
>
> I would split:
>
> ret = ipu_bridge_connect_sensors(bridge);
> if (ret)
> goto err_unregister_ipu;
>
> if (bridge->n_sensors == 0) {
> ret = -EINVAL;
> goto err_unregister_ipu;
> }

It's always hard to know which way to go on these... I wrote it that
way in my first draft. It's my prefered way as well but not everyone
agrees. I'll resend.

regards,
dan carpenter


\
 
 \ /
  Last update: 2024-05-27 18:24    [W:6.284 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site