lkml.org 
[lkml]   [2024]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v24 2/4] reset: npcm: register npcm8xx clock auxiliary bus device
Hi Tomer,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on pza/reset/next linus/master v6.9-rc7 next-20240510]
[cannot apply to pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Tomer-Maimon/dt-bindings-reset-npcm-add-clock-properties/20240510-072622
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/20240509192411.2432066-3-tmaimon77%40gmail.com
patch subject: [PATCH v24 2/4] reset: npcm: register npcm8xx clock auxiliary bus device
config: arm-wpcm450_defconfig (https://download.01.org/0day-ci/archive/20240510/202405101852.gDDWbzsx-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405101852.gDDWbzsx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405101852.gDDWbzsx-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/reset/reset-npcm.c: In function 'npcm_clock_adev_release':
drivers/reset/reset-npcm.c:391:9: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
391 | kfree(rdev);
| ^~~~~
| vfree
drivers/reset/reset-npcm.c: In function 'npcm_clock_adev_alloc':
drivers/reset/reset-npcm.c:400:16: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
400 | rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
| ^~~~~~~
| vzalloc
>> drivers/reset/reset-npcm.c:400:14: warning: assignment to 'struct npcm_clock_adev *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
400 | rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
| ^
cc1: some warnings being treated as errors


vim +400 drivers/reset/reset-npcm.c

393
394 static struct auxiliary_device *npcm_clock_adev_alloc(struct npcm_rc_data *rst_data, char *clk_name)
395 {
396 struct npcm_clock_adev *rdev;
397 struct auxiliary_device *adev;
398 int ret;
399
> 400 rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
401 if (!rdev)
402 return ERR_PTR(-ENOMEM);
403
404 rdev->base = rst_data->base;
405
406 adev = &rdev->adev;
407 adev->name = clk_name;
408 adev->dev.parent = rst_data->dev;
409 adev->dev.release = npcm_clock_adev_release;
410 adev->id = 555u;
411
412 ret = auxiliary_device_init(adev);
413 if (ret) {
414 kfree(adev);
415 return ERR_PTR(ret);
416 }
417
418 return adev;
419 }
420

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

\
 
 \ /
  Last update: 2024-05-27 18:23    [W:0.133 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site