Messages in this thread Patch in this message | | | Date | Fri, 10 May 2024 06:59:05 +0900 | From | Dominique Martinet <> | Subject | Re: [PATCH v2 1/3] perf parse-events: pass parse_state to add_tracepoint |
| |
Arnaldo Carvalho de Melo wrote on Thu, May 09, 2024 at 06:46:19PM -0300: > ⬢[acme@toolbox perf-tools-next]$ git log --oneline -1 ; time make -C tools/perf build-test > [...] > tests/parse-events.c:2274:26: error: ‘test__checkevent_tracepoint’ undeclared here (not in a function); did you mean ‘test__checkevent_breakpoint’? > 2274 | .check = test__checkevent_tracepoint, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > | test__checkevent_breakpoint > make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:105: tests/parse-events.o] Error 1 > make[6]: *** Waiting for unfinished jobs....
Sorry, didn't know about build-test; I've confirmed the problem [and will eventually want to check how to build this cleanly on nixos, it's a pain to shuffle the patch around to rebuild perf...]
It looks like the test case just needs an extra ifdef for LIBTRACEEVEENT?
---- diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c index 417d4782a520..edc2adcf1bae 100644 --- a/tools/perf/tests/parse-events.c +++ b/tools/perf/tests/parse-events.c @@ -2269,11 +2269,13 @@ static const struct evlist_test test__events[] = { .check = test__checkevent_breakpoint_2_events, /* 3 */ }, +#ifdef HAVE_LIBTRACEEVENT { .name = "9p:9p_client_req", .check = test__checkevent_tracepoint, /* 4 */ }, +#endif }; static const struct evlist_test test__events_pmu[] = { ---- I'll send a v4 with that rolled in after confirming the full build-test passes.
-- Dominique Martinet | Asmadeus
| |