Messages in this thread |  | | From | Aleksei Sviridkin <> | | Subject | [PATCH net 0/2] net: macb: fix the link speed the taprio setup reads | | Date | Wed, 2 Sep 2026 08:05:26 +0000 |
| |
Two small fixes in macb_taprio_setup_replace(), both in how it obtains the link speed it scales the schedule with.
The first: it hands phylink_ethtool_ksettings_get() a stack variable it never zeroed, while phylink fills only what the link mode provides and even reads one field back from the caller. The second: the speed check is written as "<= 0" on a u32, so SPEED_UNKNOWN passes it and turns into a 1 ns hardware limit that every entry then exceeds.
Compile-tested against net; the driver has no test surface, and no macb board here.
Aleksei Sviridkin (2): net: macb: zero the link settings taprio reads back net: macb: reject an unknown link speed in the taprio setup
drivers/net/ethernet/cadence/macb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
-- 2.53.0
|  |