Messages in this thread |  | | From | Rosen Penev <> | | Date | Wed, 8 Jul 2026 12:37:41 -0700 | | Subject | Re: [PATCH 3/3] memory: fsl_ifc: Use devm_request_irq and simplify remove |
| |
On Wed, Jul 8, 2026 at 4:04 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 04/06/2026 06:28, Rosen Penev wrote: > > - > > -err_free_nandirq: > > - if (fsl_ifc_ctrl_dev->nand_irq > 0) > > - free_irq(fsl_ifc_ctrl_dev->nand_irq, fsl_ifc_ctrl_dev); > > -err_free_irq: > > - free_irq(fsl_ifc_ctrl_dev->irq, fsl_ifc_ctrl_dev); > > - return ret; > > + return of_platform_default_populate(dev->dev.of_node, NULL, &dev->dev); > > This can be devm as well, in this patch. Not sure I follow. Although of_platform_default_populate is probably not needed here anymore. Will test.
This series means nothing though, since this driver never probes. I sent a patch but no action has been taken: https://lore.kernel.org/all/20260604043309.91280-1-rosenp@gmail.com/ > > > > } > > > > static const struct of_device_id fsl_ifc_match[] = { > > > Best regards, > Krzysztof
|  |