lkml.org 
[lkml]   [2026]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API
From
On 04/06/2026 06:28, Rosen Penev wrote:
> @@ -271,10 +265,16 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
> if (ret != 0) {
> dev_err(&dev->dev, "failed to install irq (%d)\n",
> fsl_ifc_ctrl_dev->irq);
> - goto err_unmap_nandirq;
> + goto err;
> }
>
> - if (fsl_ifc_ctrl_dev->nand_irq) {
> + /* get the nand machine irq */
> + fsl_ifc_ctrl_dev->nand_irq = platform_get_irq_optional(dev, 1);
> + if (fsl_ifc_ctrl_dev->nand_irq < 0) {
> + ret = fsl_ifc_ctrl_dev->nand_irq;

How did you test it? Looks like you change the logic and fail the probe
on missing IRQ.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2026-07-08 13:12    [W:0.088 / U:0.071 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog