Messages in this thread |  | | Date | Thu, 7 May 2026 12:13:55 +0200 | | From | Sabrina Dubroca <> | | Subject | Re: [PATCH ipsec-next v8 04/14] xfrm: fix NAT-related field inheritance in SA migration |
| |
2026-05-07, 11:56:58 +0200, Steffen Klassert wrote: > On Thu, May 07, 2026 at 11:33:09AM +0200, Sabrina Dubroca wrote: > > 2026-05-05, 06:32:43 +0200, Antony Antony wrote: > > > During SA migration via xfrm_state_clone_and_setup(), > > > nat_keepalive_interval was silently dropped and never copied to the new > > > SA. mapping_maxage was unconditionally copied even when migrating to a > > > non-encapsulated SA. > > > > mapping_maxage should be harmless (0/unused on non-encap), but I think > > migrating nat_keepalive_interval should be considered a fix: > > > > Fixes: f531d13bdfe3 ("xfrm: support sending NAT keepalives in ESP in UDP states") > > > > (maybe even split out of this series, but that would cause a conflict > > with the previous patch) > > Can this be backported without the previous patches? > If not, we might need to split it out.
git cherry-pick managed to handle the small context change, so it's probably fine like this.
-- Sabrina
|  |