Messages in this thread |  | | From | Pratyush Yadav <> | | Subject | Re: [PATCH v1 2/3] liveupdate: block outgoing session mutations during serialization | | Date | Wed, 06 May 2026 10:47:45 +0200 |
| |
On Wed, May 06 2026, Pasha Tatashin wrote:
> Introduce a 'rebooting' flag in the session header to ensure that once > serialization has started, no new outgoing session mutations (creations > or file preservations) can occur.
Would it be a better idea to hold the session header lock and locks of each session? This would prevent anyone else from getting access to any of the sessions, and we don't have to worry about all the weird cases when one might add a file to a serialized session or something similar.
Once liveupdate_reboot() returns success, there is no going back anyway so I don't think it matters much that some tasks will be left waiting.
> > Fixes: 0153094d03df ("liveupdate: luo_session: add sessions support") > Reported-by: Oskar Gerlicz Kowalczuk <oskar@gerlicz.space> > Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com> [...]
-- Regards, Pratyush Yadav
|  |