lkml.org 
[lkml]   [2026]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [EXTERNAL] [PATCH v3 04/11] ceph: add diagnostic timeout loop to wait_caps_flush()
From
Date
On Wed, 2026-05-06 at 14:34 +0300, Alex Markuze wrote:
> Hi Slava,
>
> Integer type for loop counter i
>
> The counter i tracks the number of 60-second timeout iterations. To
> overflow an int it would need roughly 4,000 years of continuous
> waiting. In practice, after CEPH_CAP_FLUSH_MAX_DUMP_COUNT (5)
> iterations the diagnostics are suppressed and the counter just ticks
> silently; nothing indexes on its value after that point.
>
> I could change it to unsigned int for cleanliness, but it wouldn't
> change behavior. Would you prefer that, or do you have a different
> concern about the counter?
>

It is not critical remark. If you believe that we can survive with integer type,
then I am OK with it.

Thanks,
Slava.


\
 
 \ /
  Last update: 2026-05-06 23:19    [W:0.093 / U:1.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog