lkml.org 
[lkml]   [2026]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] rust: dma: drop placeholder TODO comment
From
On Wed May 6, 2026 at 6:46 PM BST, Melih Emik wrote:
> The comment above Coherent already describes the outstanding design
>
> considerations around device resource lifetime.
>
> Drop the standalone placeholder TODO marker and keep the explanatory
>
> text, including a minor wording fix.
>
> No functional change intended.
>
> Signed-off-by: Melih Emik <melihemik@noirlang.tr>
> ---
> rust/kernel/dma.rs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
> index 4995ee5dc689..60c458adba0c 100644
> --- a/rust/kernel/dma.rs
> +++ b/rust/kernel/dma.rs
> @@ -580,9 +580,7 @@ fn from(value: CoherentBox<T>) -> Self {
> /// to an allocated region of coherent memory and `dma_handle` is the DMA address base of the
> /// region.
> /// - The size in bytes of the allocation is equal to size information via pointer.
> -// TODO
> -//
> -// DMA allocations potentially carry device resources (e.g.IOMMU mappings), hence for soundness
> +// DMA allocations potentially carry device resources (e.g. IOMMU mappings), hence for soundness
> // reasons DMA allocation would need to be embedded in a `Devres` container, in order to ensure
> // that device resources can never survive device unbind.
> //

The TODO here is supposed to be the heading of the next paragraph.

Best,
Gary


\
 
 \ /
  Last update: 2026-05-06 19:57    [W:0.051 / U:6.875 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog