Messages in this thread Patch in this message |  | | From | Xiaolei Wang <> | | Subject | [PATCH v2 4/4] media: imx8-isi: clean up already-initialized pipes on probe failure | | Date | Wed, 6 May 2026 11:12:10 +0800 |
| |
When mxc_isi_pipe_init() fails partway through the channel loop or when mxc_isi_v4l2_init() fails, the already initialized pipes are not cleaned up.
Fix this by calling mxc_isi_pipe_cleanup() for each already-initialized pipe in the err_xbar error path.
Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 2b76fb9c18f6..8533a979d60a 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -539,6 +539,8 @@ static int mxc_isi_probe(struct platform_device *pdev) return 0; err_xbar: + while (i--) + mxc_isi_pipe_cleanup(&isi->pipes[i]); mxc_isi_crossbar_cleanup(&isi->crossbar); return ret; -- 2.43.0
|  |