Messages in this thread Patch in this message |  | | From | Xiaolei Wang <> | | Subject | [PATCH v2 3/4] media: imx8-isi: fix isi->pipes memory leak in probe and remove | | Date | Wed, 6 May 2026 11:12:09 +0800 |
| |
mxc_isi_probe() allocates isi->pipes with kzalloc_objs() but never frees it on any probe failure path or in mxc_isi_remove(), leaking the allocation on every failed probe and every normal unbind.
Fix this by switching from kzalloc_objs() to devm_kcalloc(), which ties the allocation lifetime to the device and eliminates the need for explicit kfree() in all error paths and in mxc_isi_remove().
Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index 2d639b789910..2b76fb9c18f6 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -485,7 +485,8 @@ static int mxc_isi_probe(struct platform_device *pdev) isi->pdata = of_device_get_match_data(dev); - isi->pipes = kzalloc_objs(isi->pipes[0], isi->pdata->num_channels); + isi->pipes = devm_kcalloc(dev, isi->pdata->num_channels, + sizeof(*isi->pipes), GFP_KERNEL); if (!isi->pipes) return -ENOMEM; -- 2.43.0
|  |