lkml.org 
[lkml]   [2026]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/4] media: imx8-isi: fix resource cleanup issues
Date
This series fixes several resource management bugs in the imx8-isi driver:

- A use-after-free triggered during rmmod because crossbar pads were
freed before media links referencing them were removed.
- A memory leak of subdev active state due to missing
v4l2_subdev_cleanup() calls in crossbar and pipe cleanup paths.
- A memory leak of isi->pipes on probe failure and normal unbind.
- Missing cleanup of already-initialized pipes when probe fails
partway through the channel loop or during v4l2 init.

All four issues trace back to the original driver introduction in
cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver").

Changes in V2:
- Split the previous patch 3 ("media: imx8-isi: fix isi->pipes memory leak
in probe and remove") into two separate patches:
- Patch 3/4: fix isi->pipes memory leak by switching to devm_kcalloc()
- Patch 4/4: clean up already-initialized pipes on probe failure
- Link to V1: https://patchwork.linuxtv.org/project/linux-media/cover/20260424231926.406079-1-xiaolei.wang@windriver.com/

Xiaolei Wang (4):
media: imx8-isi: fix use-after-free on remove
media: imx8-isi: add missing v4l2_subdev_cleanup() in crossbar and
pipe
media: imx8-isi: fix isi->pipes memory leak in probe and remove
media: imx8-isi: clean up already-initialized pipes on probe failure

drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 7 +++++--
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 1 +
drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 +
3 files changed, 7 insertions(+), 2 deletions(-)

--
2.43.0


\
 
 \ /
  Last update: 2026-05-06 05:14    [W:0.170 / U:11.998 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog