lkml.org 
[lkml]   [2026]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks
Date
Hello,


for your information, the current version of the patch goes a bit too far,
as using the "usbnet_link_change" function in this context.
called from the "mac_link_up" or "mac_link_down" functions, works but
is not ideal.

With Oleksij's help, I have since been able to create a new patch
that specifically enables or disables only the RX URB submission.
I will submit the new patch as v2 of the current patch later today
or tomorrow at the latest.
I have completed testing of the new patch, and the results were positive.

PS: Sorry that I sent the first email in HTML format

Best regards
Markus


Von: patchwork-bot+netdevbpf@kernel.org <patchwork-bot+netdevbpf@kernel.org>
Gesendet: Dienstag, 5. Mai 2026 04:20:07
An: Baier, Markus
Cc: o.rempel@pengutronix.de; andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; linux@armlinux.org.uk; enelsonmoore@gmail.com; linmq006@gmail.com; linux-usb@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Betreff: Re: [PATCH net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks
 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  1 May 2026 18:39:41 +0200 you wrote:
> Commit e0bffe3e6894 ("net: asix: ax88772: migrate to phylink") replaced
> the asix_adjust_link() PHY callback with phylink's mac_link_up() and
> mac_link_down() handlers, but did not carry over the usbnet_link_change()
> notification that commit 805206e66fab ("net: asix: fix "can't send until
> first packet is send" issue") had added.
>
> As a result, the original symptom returns: when the link comes up,
> usbnet is never notified, so the RX URB submission stays dormant until
> some other event (e.g. a transmitted packet triggering the status
> endpoint interrupt) wakes it up.
>
> [...]

Here is the summary with links:
  - [net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks
    https://git.kernel.org/netdev/net/c/36bdc0e815b4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



\
 
 \ /
  Last update: 2026-05-05 12:50    [W:0.089 / U:0.775 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog