lkml.org 
[lkml]   [2026]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] sched/fair: Drop redundant RCU read lock in NOHZ kick path
Hi Dietmar,

On Tue, May 05, 2026 at 11:15:12AM +0200, Dietmar Eggemann wrote:
> On 28.04.26 16:41, Andrea Righi wrote:
>
> [...]
>
> > @@ -12799,10 +12795,10 @@ static void nohz_balancer_kick(struct rq *rq)
> > *
> > * Skip the LLC logic because it's not relevant in that case.
> > */
> > - goto unlock;
> > + goto out;
> > }
> >
> > - sds = rcu_dereference_all(per_cpu(sd_llc_shared, cpu));
> > + sds = rcu_dereference_all(per_cpu(sd_balance_shared, cpu));
>
> nit: sd_balance_shared is only defined in 2/5.

Ah, good catch! Apparently I forgot to test-build each individual patch, I'll
fix this.

Thanks,
-Andrea

\
 
 \ /
  Last update: 2026-05-05 11:22    [W:0.092 / U:5.234 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog