Messages in this thread |  | | Date | Tue, 5 May 2026 11:21:21 +0200 | | Subject | Re: [PATCH v2 4/4] arm64: dts: broadcom: bcm2712: add bcm2712-firmware compatible | | From | Krzysztof Kozlowski <> |
| |
On 05/05/2026 09:25, Gregor Herburger wrote: > The Raspberry Pi 5 firmware exposes additional features. Update the > compatible to reflect these differences. > > Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de> > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi > index b7a6bc34ae1a..7283078fd441 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi > @@ -46,7 +46,7 @@ power_button: power-button { > > firmware { > firmware: rpi-firmware { > - compatible = "raspberrypi,bcm2835-firmware", "simple-mfd"; > + compatible = "raspberrypi,bcm2712-firmware", "simple-mfd";
This breaks users without mentioning and without proper reason. "Additional features" is not a reason to break users. At least not without explaining the actual impact, but even with the impact IMO this is just wrong.
Best regards, Krzysztof
|  |