Messages in this thread |  | | Date | Tue, 5 May 2026 16:47:25 +0800 | | From | Herbert Xu <> | | Subject | Re: [PATCH v5 01/13] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk |
| |
On Thu, Apr 16, 2026 at 05:29:18PM +0530, Harshal Dev wrote: > The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC > power-domain and iface clock. Without enabling the iface clock and the > associated power-domain the ICE hardware cannot function correctly and > leads to unclocked hardware accesses being observed during probe. > > Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC > power-domain and iface clock for new devices (Eliza and Milos) introduced > in the current release (7.1) with yet-to-stabilize ABI, while preserving > backward compatibility for older devices. > > Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Document the Eliza ICE") > Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: document the Milos ICE") > Reviewed-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com> > --- > .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 +++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|  |