Messages in this thread |  | | From | "Nitka, Grzegorz" <> | | Subject | RE: [Intel-wired-lan] [PATCH v7 net-next 1/8] dpll: add generic DPLL type | | Date | Tue, 5 May 2026 07:43:29 +0000 |
| |
> -----Original Message----- > From: Loktionov, Aleksandr <aleksandr.loktionov@intel.com> > Sent: Thursday, April 30, 2026 1:49 PM > To: Nitka, Grzegorz <grzegorz.nitka@intel.com>; netdev@vger.kernel.org > Cc: Vecera, Ivan <ivecera@redhat.com>; vadim.fedorenko@linux.dev; > kuba@kernel.org; jiri@resnulli.us; edumazet@google.com; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com>; richardcochran@gmail.com; > donald.hunter@gmail.com; linux-kernel@vger.kernel.org; Kubalewski, > Arkadiusz <arkadiusz.kubalewski@intel.com>; andrew+netdev@lunn.ch; > intel-wired-lan@lists.osuosl.org; horms@kernel.org; > Prathosh.Satish@microchip.com; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; pabeni@redhat.com; > davem@davemloft.net > Subject: RE: [Intel-wired-lan] [PATCH v7 net-next 1/8] dpll: add generic DPLL > type > > > > > -----Original Message----- > > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > > Of Grzegorz Nitka > > Sent: Thursday, April 30, 2026 11:43 AM > > To: netdev@vger.kernel.org > > Cc: Vecera, Ivan <ivecera@redhat.com>; vadim.fedorenko@linux.dev; > > kuba@kernel.org; jiri@resnulli.us; edumazet@google.com; Kitszel, > > Przemyslaw <przemyslaw.kitszel@intel.com>; richardcochran@gmail.com; > > donald.hunter@gmail.com; linux-kernel@vger.kernel.org; Kubalewski, > > Arkadiusz <arkadiusz.kubalewski@intel.com>; andrew+netdev@lunn.ch; > > intel-wired-lan@lists.osuosl.org; horms@kernel.org; > > Prathosh.Satish@microchip.com; Nguyen, Anthony L > > <anthony.l.nguyen@intel.com>; pabeni@redhat.com; > davem@davemloft.net > > Subject: [Intel-wired-lan] [PATCH v7 net-next 1/8] dpll: add generic > > DPLL type > > > > Add DPLL_TYPE_GENERIC to represent DPLL devices which do not fit the > > existing PPS or EEC classes. > > > > The UAPI type is intentionally generic. During netdev discussion, > > maintainers pointed out that introducing identifiers tied to a > > specific placement or single design does not scale across ASICs and > > vendors. > > The role of a DPLL is already inferable from the spawning driver, bus > > device, and pin topology, without encoding additional purpose-specific > > taxonomy in the type name. > > > > Using a generic type keeps the UAPI extensible and avoids premature > > naming that may become incorrect as new hardware topologies are > > exposed through the DPLL subsystem. > > > > Expose the new type through UAPI and netlink specification as > > "generic". > > > > Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com> > > --- > > Documentation/netlink/specs/dpll.yaml | 3 +++ > > drivers/dpll/dpll_nl.c | 2 +- > > include/uapi/linux/dpll.h | 2 ++ > > 3 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/netlink/specs/dpll.yaml > > b/Documentation/netlink/specs/dpll.yaml > > index 40465a3d7fc2..572cf7ae5f36 100644 > > --- a/Documentation/netlink/specs/dpll.yaml > > +++ b/Documentation/netlink/specs/dpll.yaml > > @@ -138,6 +138,9 @@ definitions: > > - > > name: eec > > doc: dpll drives the Ethernet Equipment Clock > > + - > > + name: generic > > + doc: generic dpll type for devices outside PPS/EEC classes > > render-max: true > > - > > type: enum > > diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c index > > 1e652340a5d7..9a3b70ea3ae0 100644 > > --- a/drivers/dpll/dpll_nl.c > > +++ b/drivers/dpll/dpll_nl.c > > @@ -34,7 +34,7 @@ const struct nla_policy > > dpll_reference_sync_nl_policy[DPLL_A_PIN_STATE + 1] = { static const > > struct nla_policy dpll_device_id_get_nl_policy[DPLL_A_TYPE + 1] = { > > [DPLL_A_MODULE_NAME] = { .type = NLA_NUL_STRING, }, > > [DPLL_A_CLOCK_ID] = { .type = NLA_U64, }, > > - [DPLL_A_TYPE] = NLA_POLICY_RANGE(NLA_U32, 1, 2), > > + [DPLL_A_TYPE] = NLA_POLICY_RANGE(NLA_U32, 1, 3), > > I think you need especial note if you manually edit "do not edit directly" file. > Isn't it ? >
This is not manual edit. This file is generated by ynl-regen.sh script. And attached to this commit. I believe this is the way how it should be processed.
Thanks!
Grzegorz
> > }; > > > > /* DPLL_CMD_DEVICE_GET - do */ > > diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h > > index 871685f7c353..648553053cd8 100644 > > --- a/include/uapi/linux/dpll.h > > +++ b/include/uapi/linux/dpll.h > > @@ -109,10 +109,12 @@ enum dpll_clock_quality_level { > > * enum dpll_type - type of dpll, valid values for DPLL_A_TYPE > > attribute > > * @DPLL_TYPE_PPS: dpll produces Pulse-Per-Second signal > > * @DPLL_TYPE_EEC: dpll drives the Ethernet Equipment Clock > > + * @DPLL_TYPE_GENERIC: generic dpll type for devices outside PPS/EEC > > + classes > > */ > > enum dpll_type { > > DPLL_TYPE_PPS = 1, > > DPLL_TYPE_EEC, > > + DPLL_TYPE_GENERIC, > > > > /* private: */ > > __DPLL_TYPE_MAX, > > -- > > 2.39.3
|  |