Messages in this thread |  | | Date | Tue, 5 May 2026 10:31:19 +0300 | | From | Andy Shevchenko <> | | Subject | Re: [PATCH v3 2/4] i2c: designware: Convert PCI driver to use shutdown hook |
| |
On Mon, May 04, 2026 at 08:15:03PM +0000, William A. Kennington III wrote: > Convert the PCI driver to use the new i2c_dw_shutdown() hook, allowing > the controller to gracefully NACK master requests during system shutdown.
...
> +static void i2c_dw_pci_shutdown(struct pci_dev *pdev) > +{ > + struct dw_i2c_dev *i_dev = pci_get_drvdata(pdev); > + > + if (!i_dev) > + return;
In long term this is bad style from maintenance perspective. Use
struct dw_i2c_dev *i_dev;
i_dev = pci_get_drvdata(pdev); if (!i_dev) return;
> + pm_runtime_disable(&pdev->dev); > + if (!pm_runtime_status_suspended(&pdev->dev)) > + i2c_dw_shutdown(i_dev); > +}
...
> - .driver = {
> + .driver = {
Stray change.
-- With Best Regards, Andy Shevchenko
|  |