Messages in this thread Patch in this message |  | | From | Shitalkumar Gandhi <> | | Subject | [PATCH net] net: rtsn: fix mdio_node leak in rtsn_mdio_alloc() | | Date | Tue, 5 May 2026 01:33:56 +0530 |
| |
of_get_child_by_name() takes a reference. The rtsn_reset() and rtsn_change_mode() failure paths jump to out_free_bus and leak mdio_node.
Add out_put_node to drop it before falling through.
Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN") Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com> --- drivers/net/ethernet/renesas/rtsn.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/renesas/rtsn.c index 03a2669f0518..c46d991cceb5 100644 --- a/drivers/net/ethernet/renesas/rtsn.c +++ b/drivers/net/ethernet/renesas/rtsn.c @@ -797,11 +797,11 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) /* Enter config mode before registering the MDIO bus */ ret = rtsn_reset(priv); if (ret) - goto out_free_bus; + goto out_put_node; ret = rtsn_change_mode(priv, OCR_OPC_CONFIG); if (ret) - goto out_free_bus; + goto out_put_node; rtsn_modify(priv, MPIC, MPIC_PSMCS_MASK | MPIC_PSMHT_MASK, MPIC_PSMCS_DEFAULT | MPIC_PSMHT_DEFAULT); @@ -823,7 +823,8 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) priv->mii = mii; return 0; - +out_put_node: + of_node_put(mdio_node); out_free_bus: mdiobus_free(mii); return ret; -- 2.25.1
|  |