Messages in this thread |  | | Date | Tue, 5 May 2026 13:54:41 +0800 | | From | Herbert Xu <> | | Subject | Re: [PATCH] crypto: krb5 - wait for async aead completion before freeing buffer |
| |
On Sat, May 02, 2026 at 09:25:06AM -0400, Michael Bommarito wrote: > > diff --git a/crypto/krb5/rfc3961_simplified.c b/crypto/krb5/rfc3961_simplified.c > index e49cbdec7c40..c4b8e9b89c7b 100644 > --- a/crypto/krb5/rfc3961_simplified.c > +++ b/crypto/krb5/rfc3961_simplified.c > @@ -543,6 +543,7 @@ ssize_t krb5_aead_encrypt(const struct krb5_enctype *krb5, > size_t data_offset, size_t data_len, > bool preconfounded) > { > + DECLARE_CRYPTO_WAIT(wait); > struct aead_request *req; > ssize_t ret, done; > size_t bsize, base_len, secure_offset, secure_len, pad_len, cksum_offset; > @@ -588,9 +589,10 @@ ssize_t krb5_aead_encrypt(const struct krb5_enctype *krb5, > iv = buffer + krb5_aead_size(aead); > > aead_request_set_tfm(req, aead); > - aead_request_set_callback(req, 0, NULL, NULL); > + aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG, > + crypto_req_done, &wait); > aead_request_set_crypt(req, sg, sg, secure_len, iv); > - ret = crypto_aead_encrypt(req); > + ret = crypto_wait_req(crypto_aead_encrypt(req), &wait); > if (ret < 0) > goto error;
Since this code was written synchronously, it's probably best to change the allocation to filter out async algorithms:
ci = crypto_alloc_aead(krb5->encrypt_name, 0, CRYPTO_ALG_ASYNC);
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|  |