lkml.org 
[lkml]   [2026]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: move phys_mem_access_prot_allowed to header
On Tue, May 5, 2026, at 03:01, Rosen Penev wrote:
> phys_mem_access_prot_allowed is only implemented for X86. For others, it
> returns 1. Move it to header to avoid using __weak.
>
> Fixes compilation with make LLVM=1 ARCH=mips

Can you describe what exactly goes wrong here on mips?

> @@ -239,12 +239,6 @@ static ssize_t write_mem(struct file *file, const
> char __user *buf,
> return written;
> }
>
> -int __weak phys_mem_access_prot_allowed(struct file *file,
> - unsigned long pfn, unsigned long size, pgprot_t *vma_prot)
> -{
> - return 1;
> -}
> -

Removing __weak functions is usually an improvement, but I think
we can go further here, see the discussion from last year at

https://lore.kernel.org/all/20250520152030.1499670-1-arnd@kernel.org/#t

Arnd

\
 
 \ /
  Last update: 2026-05-05 07:55    [W:0.134 / U:6.006 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog