lkml.org 
[lkml]   [2026]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets
On Tue, May 05, 2026 at 02:16:23PM +0530, Sathvika Vasireddy wrote:
> switch (opcode) {
> + case 16:

Like case 18 below, this wants a comment describing which instruction
this is; bclr ?

> + if (ins & 1)
> + typ = INSN_OTHER;
> + else
> + typ = INSN_JUMP_CONDITIONAL;
> + imm = ins & 0xfffc;
> + if (imm & 0x8000)
> + imm -= 0x10000;
> + insn->immediate = imm | aa;
> + break;
> +
> case 18: /* b[l][a] */
> if (ins == 0x48000005) /* bl .+4 */
> typ = INSN_OTHER;

\
 
 \ /
  Last update: 2026-05-05 16:49    [W:0.190 / U:33.759 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog