Messages in this thread |  | | From | Joshua Crofts <> | | Date | Tue, 5 May 2026 16:05:09 +0200 | | Subject | Re: [PATCH v5 0/8] iio: light: si1133: driver cleanup |
| |
On Tue, 5 May 2026 at 14:34, Jonathan Cameron <jic23@kernel.org> wrote: > > On Tue, 05 May 2026 09:31:25 +0200 > Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org> wrote: > > > This series deals with the cleanup and modernization of the Silicon > > Labs SI1133 UV/Ambient light sensor. > > > > What seemed like a simple checkpatch cleanup turned out to be more > > complex, therefore I've ended up doing a patch series instead. > > > > Changes include: > > - adding missing headers > > - removing unused macros > > - adding guard(mutex)() support > > - code style fixes > > - race condition fixes reported by Sashiko > > > > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com> > Applied. > > Sashiko is far from happy but I think what it is picking up on > are either wrong (like the i2c stuff) or about other potential issues > in the driver. > > Correctly recovering from every error case is fine so I tend > to think of that as best effort only rather than worrying too much > about the more complex parts.
It seems that Sashiko ends up finding more regressions after fixing one it reported. It's a bit misleading when it reports multiple regressions and once you open the report it's all "this wasn't introduced by the patch, but - ".
> So applied with that one tweak to where timeout is assigned in patch 7.
Thanks, it does look better this way.
-- Kind regards
CJD
|  |