Messages in this thread |  | | Subject | Re: [PATCH net] netpoll: pass buffer size to egress_dev() to avoid MAC truncation | | From | patchwork-bot+netdevbpf@kernel ... | | Date | Tue, 05 May 2026 02:00:08 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Fri, 01 May 2026 02:58:41 -0700 you wrote: > egress_dev() formats np->dev_mac via snprintf() but receives buf as > a bare char *, so it cannot derive the buffer size from the pointer. The > size argument was hardcoded to MAC_ADDR_STR_LEN (3 * ETH_ALEN - 1 = 17), > which is silly wrong in two ways: > > 1) misleading kernel log output on the MAC-selected target path > (np->dev_name[0] == '\0'); for example "aa:bb:cc:dd:ee:ff doesn't > exist, aborting" was logged as "aa:bb:cc:dd:ee:f doesn't exist, > aborting". > > [...]
Here is the summary with links: - [net] netpoll: pass buffer size to egress_dev() to avoid MAC truncation https://git.kernel.org/netdev/net/c/76b93a810757
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
|  |