lkml.org 
[lkml]   [2026]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations
On Wed, May 20, 2026 at 09:22:49AM +0800, liulongfang wrote:
> On 2026/5/11 8:49, Chenghai Huang wrote:
> > From: lizhi <lizhi206@huawei.com>
> >
> > Lower the priority of HiSilicon's crypto implementations to allow more
> > suitable alternatives to be selected. For example, certain kernel
> > use-cases do not benefit from HiSilicon's symmetric crypto algorithms.
> > This change ensures that more appropriate options are chosen first while
> > retaining HiSilicon's implementations as alternatives.
> >
> > Signed-off-by: lizhi <lizhi206@huawei.com>
> > Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
> > ---
> > drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c
> > index 2471a4dd0b50..77e0e03cbcab 100644
> > --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c
> > +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c
> > @@ -20,7 +20,7 @@
> > #include "sec.h"
> > #include "sec_crypto.h"
> >
> > -#define SEC_PRIORITY 4001
> > +#define SEC_PRIORITY 80
> > #define SEC_XTS_MIN_KEY_SIZE (2 * AES_MIN_KEY_SIZE)
> > #define SEC_XTS_MID_KEY_SIZE (3 * AES_MIN_KEY_SIZE)
> > #define SEC_XTS_MAX_KEY_SIZE (2 * AES_MAX_KEY_SIZE)
> >
>
> Reviewed-by: Longfang Liu <liulongfang@huawei.com>

Makes sense, but perhaps this driver should just be removed entirely?

- Eric

\
 
 \ /
  Last update: 2026-05-20 03:36    [W:0.065 / U:2.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog