Messages in this thread |  | | Date | Sat, 2 May 2026 05:05:11 +0200 | | From | Willy Tarreau <> | | Subject | Re: [PATCH v3 0/2] nolibc: Add fallocate() |
| |
On Fri, May 01, 2026 at 01:41:23AM +0900, Daniel Palmer wrote: > While poking around with my "static PIE for nommu" series I found > I needed fallocate(). Implementing it turned out a bit more > interesting than I thought it would be due to how the offset and > size need to be passed on 32bit machines. > > v3: > - Reworked the test a bit, ran it on all the targets I could get > to run (s390, loongarch and sh currently don't work for me). > sparc32 doesn't seem to support fallocate() so made it skip > the test. > - Rebase on nolibc/for-next with the large file support bits. > > v2: > - Addressed Thomas' comments > - Trial and error'd a test for the arguments being passed correctly. > Hopefully someone smarter than I am can tell if it actually works.
The series looks good to me, I don't have any particular comment, but let's wait for Thomas since he's been reviewing it from day one.
Acked-by: Willy Tarreau <w@1wt.eu>
Thanks, Willy
|  |