lkml.org 
[lkml]   [2026]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/fsl-dcu: Remove redundant unregister call in connector destroy
On Tue, May 19, 2026 at 01:37:55AM +0530, Souradipto Das wrote:
> Remove the explicit call to drm_connector_unregister() inside the
> fsl_dcu_drm_connector_destroy() callback.
>
> During driver unload, the DRM core automatically unregisters all
> connectors via drm_dev_unregister() -> drm_modeset_unregister_all().
> Later, when the connector reference count drops to zero during
> drm_mode_config_cleanup(), the core calls drm_connector_free(),
> which invokes the driver's .destroy callback.
>
> Calling drm_connector_unregister() inside the destructor is
> redundant as the userspace sysfs interfaces have already been
> cleaned up.
>
> Signed-off-by: Souradipto Das <souradiptodas6@gmail.com>
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2026-05-19 00:10    [W:0.048 / U:6.607 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog