lkml.org 
[lkml]   [2026]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drm/fsl-dcu: Remove redundant unregister call in connector destroy
Date
Remove the explicit call to drm_connector_unregister() inside the
fsl_dcu_drm_connector_destroy() callback.

During driver unload, the DRM core automatically unregisters all
connectors via drm_dev_unregister() -> drm_modeset_unregister_all().
Later, when the connector reference count drops to zero during
drm_mode_config_cleanup(), the core calls drm_connector_free(),
which invokes the driver's .destroy callback.

Calling drm_connector_unregister() inside the destructor is
redundant as the userspace sysfs interfaces have already been
cleaned up.

Signed-off-by: Souradipto Das <souradiptodas6@gmail.com>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
index 84eff7519e32..0d077e507a2d 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
@@ -41,7 +41,6 @@ int fsl_dcu_drm_encoder_create(struct fsl_dcu_drm_device *fsl_dev,

static void fsl_dcu_drm_connector_destroy(struct drm_connector *connector)
{
- drm_connector_unregister(connector);
drm_connector_cleanup(connector);
}

--
2.43.0

\
 
 \ /
  Last update: 2026-05-18 22:09    [W:0.052 / U:11.715 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog