Messages in this thread |  | | Date | Fri, 15 May 2026 09:19:44 +0200 | | From | Krzysztof Kozlowski <> | | Subject | Re: [PATCH 2/5] dt-bindings: connector: Add fsl,io-connector binding |
| |
On Sat, May 09, 2026 at 11:48:43AM +0900, Chancel Liu wrote: > The NXP I/O connector represents a physically present I/O connector on > the base board. It acts as a nexus that exposes a constrained set of > I/O resources, such as GPIOs, clocks, PWMs and interrupts, through > fixed electrical wiring. All actual hardware providers reside on the > base board. The connector node only defines index-based mappings to > those providers. > > Signed-off-by: Chancel Liu <chancel.liu@nxp.com> > --- > .../bindings/connector/fsl,io-connector.yaml | 94 +++++++++++++++++++ > 1 file changed, 94 insertions(+) > create mode 100644 Documentation/devicetree/bindings/connector/fsl,io-connector.yaml > > diff --git a/Documentation/devicetree/bindings/connector/fsl,io-connector.yaml b/Documentation/devicetree/bindings/connector/fsl,io-connector.yaml > new file mode 100644 > index 000000000000..8b5038a2332e > --- /dev/null > +++ b/Documentation/devicetree/bindings/connector/fsl,io-connector.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/connector/fsl,io-connector.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP I/O Connector > + > +maintainers: > + - Frank Li <Frank.li@nxp.com> > + - Chancel Liu <chancel.liu@nxp.com> > + > +description: > + The NXP I/O connector represents a physically present I/O connector on the > + base board. It acts as a nexus that exposes a constrained set of I/O > + resources, such as GPIOs, clocks, PWMs and interrupts, through fixed > + electrical wiring. All actual hardware providers reside on the base board. > + The connector node only defines index-based mappings to those providers. > + > +properties: > + compatible: > + const: fsl,io-connector
Everything is IO. Everything is connector, so your compatible does not match requirements from writing bindings.
> + > + gpio-controller: true > + > + '#gpio-cells': > + const: 2 > + > + gpio-map: > + $ref: /schemas/types.yaml#/definitions/uint32-matrix
You do not need to redefine the types. You need constraints, though.
> + > + gpio-map-mask: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + > + gpio-map-pass-thru: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + > + '#clock-cells': > + const: 1 > + > + clock-map: > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > + clock-map-mask: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + > + clock-map-pass-thru: > + $ref: /schemas/types.yaml#/definitions/uint32-array
I do not see these defined anywhere. I also checked cover letter for references for pulls to dtschema.
> + > + pwm-map: > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > + pwm-map-mask: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + > + pwm-map-pass-thru: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + > + '#address-cells': > + const: 0 > + > + interrupt-controller: true > + > + "#interrupt-cells":
Use consistent quotes.
> + const: 2 > + > + interrupt-map: true > + > + interrupt-map-mask: true > + > +required: > + - compatible
You need to require the properties. You have a FIXED connector, so it has fixed set of features.
Best regards, Krzysztof
|  |