lkml.org 
[lkml]   [2026]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] gpib: lpvo_usb_gpib: fix heap buffer overflow in lpvo_do_write()
Date
The memcpy in lpvo_do_write() uses the original unbounded 'count' parameter instead of the capped 'writesize', causing a heap buffer overflow when a user writes more than MAX_TRANSFER (3584 bytes) to /dev/lpvo_raw%d.

Fix by using 'writesize' which is already capped to MAX_TRANSFER.

Cc: stable@vger.kernel.org
Signed-off-by: Aditya <mail4adityaa@gmail.com>
---
drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index e6ea9422d6f2..ff7cef08031d 100644
--- a/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -1638,7 +1638,7 @@ static ssize_t lpvo_do_write(struct lpvo *dev, const char *buffer, size_t count)
goto error;
}

- memcpy(buf, buffer, count);
+ memcpy(buf, buffer, writesize);

/* this lock makes sure we don't submit URBs to gone devices */
mutex_lock(&dev->io_mutex);
--
2.43.0

\
 
 \ /
  Last update: 2026-05-14 01:22    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog