lkml.org 
[lkml]   [2026]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] PCI: Export pci_parent_bus_reset() for drivers to use
From
On 5/14/26 11:39 AM, Leon Romanovsky wrote:
> On Tue, May 12, 2026 at 11:17:29AM +0100, Maciej W. Rozycki wrote:
>> On Tue, 12 May 2026, Leon Romanovsky wrote:
>>
>>>> Export pci_parent_bus_reset() so that drivers do not duplicate it.
>>>> Document the interface.
>> [...]
>>>
>>> I wouldn't recommend doing this solely for hfi1. The driver is likely to be
>>> removed or significantly changed soon.
>>>
>>> https://lore.kernel.org/linux-rdma/177516078937.637585.1447184858924347033.stgit@awdrv-04.cornelisnetworks.com/
>>
>> Thank you for the pointer. FWIW as per the cover letter I have no own
>> interest in the driver and offered this cleanup as a general code quality
>> improvement.
>>
>> Dennis, please clarify your position, and if you'd rather this change
>> wasn't made, then I'll drop the patches from my local verification setup
>> and won't offer them again.
>
> Let me put on my RDMA maintainer hat.
>
> Since hfi1 is the only user of this newly exported symbol,
> and it resides within RDMA, please drop this patch.

I would agree there.

-Denny


\
 
 \ /
  Last update: 2026-05-14 18:31    [W:0.067 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog