lkml.org 
[lkml]   [2026]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/13] verification/rvgen: Switch LTL parser to Lark
Date
Gabriele Monaco <gmonaco@redhat.com> writes:
> It looks very neat! I didn't go through it fully just yet, though.
> This one works fine but there's a nit: the ASTNode's id starts from 1, but
> apparently the new grammar consider RULE as a node too, this results in
> variables in the generated header file starting from val2 (rather than val1).
>
> Unless I missed something here, we should probably start from 0:

Yep, thanks!

> Also it doesn't gracefully handle an invalid syntax, but that's probably still a
> work in progress.

We could catch Lark's exception. I will look into it.

Nam

\
 
 \ /
  Last update: 2026-05-10 20:19    [W:0.169 / U:4.605 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog