Messages in this thread |  | | From | Alexandre Courbot <> | | Subject | [PATCH v3 0/5] rust: add `bitfield!` macro | | Date | Fri, 01 May 2026 15:03:17 +0900 |
| |
This is the continuation of the `bitfield!` macro which started alongside the `register!` one before being temporarily integrated into it [1].
Thanks for all the feedback on v2; I believe this version addresses all of it, modulo Eliot's suggestion for more explicit range error messages. Since this is not fundamentally broken, I'd like to address this in a follow-up change to keep the series focused on the macro extraction from `register!`.
This version is based on today's `rust-next`, which happens to be `7.1-rc1`. If review proves satisfying, I see several possible merge strategies, the one with the least friction being patches 1 and 2 are merged into the rust tree this cycle, followed by patches 3-5 via the I/O and DRM trees during the following cycle. This path would not require any signed tag.
[1] https://lore.kernel.org/all/20260120-register-v1-0-723a1743b557@nvidia.com/
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> --- Changes in v3: - Split patch 1 into the addition of the `bitfield!` macro and its use in the `io` module. - Mention reserved field names in `bitfield!`'s doccomment. - Properly order fields in the KUnit test. - Add a Kconfig option for building the KUnit tests. - Document behavior on non-covered bits. - Document support for signed fields and storage types (TL;DR: not supported). - Move `nova-core`'s `bitfield` module deletion into its own patch. - Link to v2: https://patch.msgid.link/20260409-bitfield-v2-0-23ac400071cb@nvidia.com
--- Alexandre Courbot (4): rust: extract `bitfield!` macro from `register!` rust: io: use the `bitfield!` macro in `register!` gpu: nova-core: switch to kernel bitfield macro gpu: nova-core: remove the driver-local `bitfield!` macro
Joel Fernandes (1): rust: bitfield: Add KUnit tests for bitfield
MAINTAINERS | 8 + drivers/gpu/nova-core/bitfield.rs | 329 -------------- drivers/gpu/nova-core/gsp/fw.rs | 11 +- drivers/gpu/nova-core/nova_core.rs | 3 - lib/Kconfig.debug | 12 + rust/kernel/bitfield.rs | 865 +++++++++++++++++++++++++++++++++++++ rust/kernel/io/register.rs | 246 +---------- rust/kernel/lib.rs | 1 + 8 files changed, 894 insertions(+), 581 deletions(-) --- base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 change-id: 20260408-bitfield-6e18254f4fdc
Best regards, -- Alexandre Courbot <acourbot@nvidia.com>
|  |