lkml.org 
[lkml]   [2026]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 07/10] vfio: Enable cdev noiommu mode under iommufd
On Thu, Apr 02, 2026 at 10:11:43PM -0700, Jacob Pan wrote:
> @@ -392,6 +398,16 @@ void vfio_unregister_group_dev(struct vfio_device *device)
> bool interrupted = false;
> long rc;
>
> + /*
> + * For noiommu devices without a container, thus no dummy group,
> + * simply delete and unregister to balance refcount.
> + */
> + if (device->noiommu && !vfio_device_has_group(device)) {
> + vfio_device_del(device);
> + vfio_device_put_registration(device);
> + return;
> + }
> +

Sashiko points out this can't just skip the waiting even for no-iommu
mode, it isn't linked to groups and containers but the lifecylce of
the open FD.

Maybe just stick a !group inside vfio_device_group_unregister() is
sufficient?

Jason

\
 
 \ /
  Last update: 2026-04-09 20:49    [W:0.125 / U:10.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog