Messages in this thread |  | | From | Prithvi Tambewagh <> | | Subject | [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs | | Date | Thu, 9 Apr 2026 19:20:21 +0530 |
| |
This patch series focuses on code cleanup in drivers/staging/rtl8723bs, majorly focusing on fixing checkpatch warnings of constant being on right side of test in comparisons, deletion of empty if block ,use of read_poll_timeout_atomic(), and other code simplifications.
Changes since v3: - Rebased the patches on top of staging-next - Remove compilation output from cover letter - Add changes in each patch version in cover letter
v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
Changes since v2: - Create patch series, each doing one logical thing - Use read_poll_timeout_atomic() in _is_fw_read_cmd_down() - Use single return statement instead of if-else blocks containing return true and return false, in IsFrameTypeCtrl() - Remove unnecessary changes from the patches - Convey testing status of the patches
v2 link: https://lore.kernel.org/linux-staging/20260403094647.fmgop6xh2cjpit3s@inspiron/T/#m3d08fd012119772ea55df48eea80abbea34e8548
Changes since v1: - Check for more changes of the type of placing constant on right side of comparison/test in drivers/staging/rtl8723bs/
v1 link: https://lore.kernel.org/linux-staging/20260323145214.ubhshy2gwp52j5zh@inspiron/T/#mc3b693b37c49fbdde89171b7f1bf61b7ba8eb964
This patch series is compile tested using the following commands, which include setting the necessary configurations: 1. make defconfig 2. scripts/config --enable CONFIG_STAGING 3. scripts/config --module CONFIG_MMC 4. scripts/config --module CONFIG_RTL8723BS 5. make olddefconfig 6. make -j$(nproc) 7. git rebase -i --exec "make -j$(nproc) M=drivers/staging/rtl8723bs" HEAD~5
However, as Luka reviewed v3 - since these are only style changes, testing is not necessary, so I dropped RFT tag from the patch series.
Prithvi Tambewagh (5): staging: rtl8723bs: move constant to right side of test in comparison staging: rtl8723bs: remove empty if statement block staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl() staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase()
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 5 +---- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 11 +++++------ drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++----------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- drivers/staging/rtl8723bs/include/wifi.h | 5 +---- 9 files changed, 29 insertions(+), 40 deletions(-)
-- 2.34.1
|  |