Messages in this thread Patch in this message |  | | From | Krzysztof Kozlowski <> | | Subject | [PATCH 3/3] arm64: tegra: Correct Tegra234 p3740 interrupt flags | | Date | Mon, 6 Apr 2026 08:49:38 +0200 |
| |
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 => IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 => IRQ_TYPE_EDGE_RISING
Realtek RT5540 codec driver requests interrupt on rising edge, so correct the interrupt flags, assuming the author of the code wanted the similar logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_HIGH => IRQ_TYPE_EDGE_RISING
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts index 9ce55b4d2de8..97cede1fcb70 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts @@ -75,7 +75,7 @@ rt5640: audio-codec@1c { compatible = "realtek,rt5640"; reg = <0x1c>; interrupt-parent = <&gpio>; - interrupts = <TEGRA234_MAIN_GPIO(F, 3) GPIO_ACTIVE_HIGH>; + interrupts = <TEGRA234_MAIN_GPIO(F, 3) IRQ_TYPE_EDGE_RISING>; clocks = <&bpmp TEGRA234_CLK_AUD_MCLK>; clock-names = "mclk"; -- 2.51.0
|  |