lkml.org 
[lkml]   [2026]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/19] spi: omap2-mcspi: switch to managed controller allocation
On Thu, Apr 30, 2026 at 09:12:49AM +0200, Johan Hovold wrote:
> On Thu, Apr 30, 2026 at 09:30:40AM +0900, Mark Brown wrote:
> > On Wed, Apr 29, 2026 at 11:13:32AM +0200, Johan Hovold wrote:
> > > @@ -1556,7 +1553,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
> > > status = omap2_mcspi_request_dma(mcspi,
> > > &mcspi->dma_channels[i]);
> > > if (status == -EPROBE_DEFER)
> > > - goto free_ctlr;
> > > + return status;
> > > }

> > Here we return directly...

> > ...which skips the _release_dma() as well as the put - I think the label
> > needs a rename and the goto keeping (or some more refactoring to also
> > use devm for the DMA, but that's more work).

> This works as intended since omap2_mcspi_request_dma() cleans up after
> itself on failure.

This is in a loop so there might be previous calls that succeeded and
need unwinding.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2026-04-30 12:13    [W:0.090 / U:43.961 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog