Messages in this thread |  | | Date | Thu, 30 Apr 2026 19:05:11 +0900 | | From | Mark Brown <> | | Subject | Re: [PATCH 18/19] spi: omap2-mcspi: switch to managed controller allocation |
| |
On Thu, Apr 30, 2026 at 09:12:49AM +0200, Johan Hovold wrote: > On Thu, Apr 30, 2026 at 09:30:40AM +0900, Mark Brown wrote: > > On Wed, Apr 29, 2026 at 11:13:32AM +0200, Johan Hovold wrote: > > > @@ -1556,7 +1553,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev) > > > status = omap2_mcspi_request_dma(mcspi, > > > &mcspi->dma_channels[i]); > > > if (status == -EPROBE_DEFER) > > > - goto free_ctlr; > > > + return status; > > > }
> > Here we return directly...
> > ...which skips the _release_dma() as well as the put - I think the label > > needs a rename and the goto keeping (or some more refactoring to also > > use devm for the DMA, but that's more work).
> This works as intended since omap2_mcspi_request_dma() cleans up after > itself on failure.
This is in a loop so there might be previous calls that succeeded and need unwinding. [unhandled content-type:application/pgp-signature] |  |