lkml.org 
[lkml]   [2026]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/19] spi: omap2-mcspi: switch to managed controller allocation
On Wed, Apr 29, 2026 at 11:13:32AM +0200, Johan Hovold wrote:
> Switch to device managed controller allocation to simplify error
> handling and to avoid having to take another reference during
> deregistration.

> @@ -1556,7 +1553,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
> status = omap2_mcspi_request_dma(mcspi,
> &mcspi->dma_channels[i]);
> if (status == -EPROBE_DEFER)
> - goto free_ctlr;
> + return status;
> }

Here we return directly...

> @@ -1604,7 +1601,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> free_ctlr:
> omap2_mcspi_release_dma(ctlr);
> - spi_controller_put(ctlr);

...which skips the _release_dma() as well as the put - I think the label
needs a rename and the goto keeping (or some more refactoring to also
use devm for the DMA, but that's more work).
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2026-04-30 02:31    [W:0.150 / U:0.141 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog