Messages in this thread |  | | Date | Thu, 30 Apr 2026 19:38:39 +0200 | | From | Greg KH <> | | Subject | Re: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name |
| |
On Thu, Apr 30, 2026 at 01:30:45PM -0400, Bentley Blacketer wrote: > The original dev_info call was intentionally temporary, with a FIXME > comment noting it should be downgraded to dev_dbg once modules with > valid VID/PID values were common. Project Ara was cancelled in 2016, > so that time has long passed. > > Remove the FIXME comment and downgrade to dev_dbg as originally intended. > > Tested via code inspection only, as Project Ara hardware is no longer > available. > > Signed-off-by: Bentley Blacketer <sonionwhat@gmail.com> > Signed-off-by: Bentley Blacketer <sonionwhat@gmail.com>
Why twice?
> --- > drivers/staging/greybus/bootrom.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-)
No list of what changed from previous versions?
> > diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c > index 83921d90c..058044ba7 100644 > --- a/drivers/staging/greybus/bootrom.c > +++ b/drivers/staging/greybus/bootrom.c > @@ -163,18 +163,13 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) > * > * XXX Name it properly.. > */ > - snprintf(firmware_name, sizeof(firmware_name), > +snprintf(firmware_name, sizeof(firmware_name),
Why this change?
Please always run your patches through checkpatch.pl before sending them out.
thanks,
greg k-h
|  |